-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not ignore column-restricted INSERT privileges #57810
Conversation
NOTE: based on PR GH-57802 |
8b93068
to
e0c4a59
Compare
d1f0156
to
7c4c462
Compare
This is now ready for review and has unit test. |
Closes qgisGH-28835 Includes testcase
7c4c462
to
a244a19
Compare
The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
sql += QString( ",has_table_privilege(%1,'UPDATE')" // 5 | ||
",has_table_privilege(%1,'UPDATE')" ) // 6 | ||
.arg( quotedValue( mQuery ) ); | ||
sql += QString( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintaining PostgreSQL < 8.4 code paths looks like self inflicted pain at that point, given it has been long unsupported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. but it's better done in an ad-hoc PR
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-57810-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick a244a19d9f7b7fea580ca6bca413eb047479cbe0
# Push it to GitHub
git push --set-upstream origin backport-57810-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports Then, create a pull request where the |
See GH-28835