Add options to override locale and number group sep. #7337

elpaso · 2018-06-29T12:55:58Z

@m-kuhn would you like to give this a try?

m-kuhn · 2018-06-29T12:57:28Z

Can you add a screenshot?

elpaso · 2018-06-29T13:00:12Z

m-kuhn · 2018-06-29T13:06:31Z

I think it's quite obscure to know what happens without in-depth knowledge of locales.

I'd be in favour of

a "No locale formatting" radio button as a shortcut to the C locale
a preview of what numbers are rendered with the current setting

elpaso · 2018-06-29T13:09:54Z

The preview is actually a good idea, I was going to make it.
Btw, locale also affects dates formatting, that's why C locale would probably be a bad choice in most (non US) situations.

m-kuhn · 2018-06-29T13:16:47Z

So how would one get to the desired result of no separators but local date representation?

elpaso · 2018-06-29T13:28:57Z

AFAIK: no way

elpaso · 2018-06-29T13:29:30Z

... unless you change the settings at the OS level

m-kuhn · 2018-06-29T13:39:54Z

Maybe it's worth a try to overwrite LC_NUMERIC on environment variable level and test it for portability?

elpaso · 2018-06-29T13:43:24Z

Is that supported on not-unix?

elpaso · 2018-06-29T13:46:05Z

maybe: https://msdn.microsoft.com/en-us/library/ftyz68a0.aspx

m-kuhn · 2018-06-29T13:48:18Z

I've got no idea, that's why I wrote "test it for portability".

Options that I can see at the moment

Upstream patch for QLocale
Find an approach to trick OS settings (like env variables)
if (user.reallyPrefers('SystemLocale')) behavior for numeric representations in attribute table and friends (do not completely rely on broken QLocale)
Revert

elpaso · 2018-06-29T14:07:22Z

nyalldawson · 2018-06-29T23:29:21Z

Just thinking...

I like the direction this is going in general, but for attribute formatting my preference would probably be:

always default to no thousand separator
have an option in the numeric editor widgets to show thousand separator, but not-enabled by default

What's everyone elses thoughts?

elpaso · 2018-06-30T07:07:00Z

I don't really mind if it is enabled by default or not as long as it's possible to enable it.

Thousands grouping increase readability and it is an important feature for visually impaired and older people.

m-kuhn · 2018-06-30T11:31:44Z

I'm still afraid Germans (just an example) with a preference for mm.dd.yyyy date style, € as currency and . as separator don't prefer the current behaviour over 3.0 behaviour and I can't see what they are supposed to do. And in case it's unclear, I'm blaming Qt here for the QLocale implementation.

jef-n · 2018-06-30T15:10:50Z

I for one never missed the thousands separator - and now that it's there I find it annoying - not as much as I would hate mm.dd.yyyy - but close ;) Adding a option to get rid of it is nice. Thanks.

BTW I use ISO yyyy-mm-dd where I can (as it sorts well lexically), then dd.mm.yyyy, which is at least still in reversed order, but no idea why anyone would ever consider m/d/yyyy a preferable order.

elpaso · 2018-07-02T06:35:53Z

Ok, I don't think the situation is too bad now:

group separator is now hidden by default
default locale are taken from system locale (so you'll get your locale's decimal point)
dates/time formats are not affected because the date widget use its own formatting options (and it uses ISO by default anyway)

andreasneumann · 2018-07-02T06:51:51Z

Hi @elpaso - thanks for looking into this and working on it!

In Switzerland, we have the problem that both the "." and the "," can be used as decimal separator. However, the system locale "de_CH" forces one into using the ",". Something that the majority of the Swiss QGIS users probably don't like. We had the "." as decimal point for almost two decades now, and suddenly everything switches to the ",". Very annoying for us.

Can we make also the decimal separator configurable?

See https://en.wikipedia.org/wiki/Decimal_separator where you can see that some provinces in Switzerland use the "." and some the ",".

elpaso · 2018-07-02T06:56:46Z

@andreasneumann the decimal point is configurable: just choose a locale which uses a dot as decimal point (such as EN_us for .)

andreasneumann · 2018-07-02T07:20:29Z

@elpaso - ok that's what we'll have to do. Hope it doesn't have any other side effects.

elpaso · 2018-07-02T07:39:45Z

@andreasneumann there shouldn't be any side-effect, but you can check it right now in you 3.2 installation: just run this code right after launching QGIS:

from qgis.PyQt.QtCore import  QLocale
locale = QLocale('EN_us')  # Or whatever you want to test
locale.setNumberOptions(locale.numberOptions() | QLocale.OmitGroupSeparator) # Hide thousand group
locale.setDefault(locale)

this is in effect immediately but you'll need to re-open the attribute table of the forms to get them updated.

... the translations available in QGIS.

nyalldawson · 2018-07-02T23:15:18Z

src/app/main.cpp

@@ -1142,9 +1142,18 @@ int main( int argc, char *argv[] )
  /* Translation file for QGIS.
   */
  QString i18nPath = QgsApplication::i18nPath();
-  QString myUserLocale = mySettings.value( QStringLiteral( "locale/userLocale" ), "" ).toString();
+  QString myUserTranslation = mySettings.value( QStringLiteral( "locale/userLocale" ), "" ).toString();


Can we drop the outdated "my" prefix here?

nyalldawson · 2018-07-02T23:16:24Z

src/app/main.cpp

+  QLocale currentLocale;
+  if ( myShowGroupSeparatorFlag )
+  {
+    currentLocale.setNumberOptions( currentLocale.numberOptions() &= !QLocale::NumberOption::OmitGroupSeparator );


Shouldn't this be ~QLocale::NumberOption::OmitGroupSeparator?

nyalldawson · 2018-07-02T23:17:52Z

src/app/qgsoptions.cpp

@@ -96,6 +96,8 @@ QgsOptions::QgsOptions( QWidget *parent, Qt::WindowFlags fl, const QList<QgsOpti
  connect( mCustomVariablesChkBx, &QCheckBox::toggled, this, &QgsOptions::mCustomVariablesChkBx_toggled );
  connect( mCurrentVariablesQGISChxBx, &QCheckBox::toggled, this, &QgsOptions::mCurrentVariablesQGISChxBx_toggled );
  connect( buttonBox, &QDialogButtonBox::helpRequested, this, &QgsOptions::showHelp );
+  connect( cboGlobalLocale, static_cast<void ( QComboBox::* )( int )>( &QComboBox::currentIndexChanged ), [ = ]( int ) { updateSampleLocaleText( ); } );


FYI (not a blocker) you can use qgis::overload< int >::of( &QComboBox::currentIndexChanged ) instead - it's a bit more compact than the static_cast version

nyalldawson · 2018-07-02T23:18:26Z

src/app/qgsoptions.cpp

+  QLocale locale( cboGlobalLocale->currentData( ).toString() );
+  if ( cbShowGroupSeparator->isChecked( ) )
+  {
+    locale.setNumberOptions( locale.numberOptions() &= ! QLocale::NumberOption::OmitGroupSeparator );


Again - should be ~, not !

veikkoeeva · 2018-11-04T19:37:07Z

I realize this is an old thread, but I got here via search engine and seems to have the most relevant discussion (I'm not sure if I should open a new issue).

I experience a bit of a bugger issue with fi-Fi (I have fi-FI Windows 10) that shows in the picture. If I put in comma separated decimal values, it appears the raster data set bounds are just set to [0, 0] and nothing shows on the map. It's not also possible to insert . in the field either from the keyboard or copying. On the other hand I tried to change the locale to en-GB whilee keeping the language in Finnish, but there's some other problem I think interpreting decimal numbers wrong and hence the visualization fails in other ways.

I do appreciate the translation and respecting system locale. I also like the idea being able to set program locale independently of the system locale (i.e. I'd set it into Finnish on a company machine that's English). It appears to be the internal reprsentation isn't in some invariant form and things go wrong. I don't know enough to tell where's the problem (calling command line software?). I have produced the geotiff raster data set using gdalwrap and gdal_translate in fi-FI system without anything else, in case this is an important piece of information.

QGISin versio	3.4.0-Madeira	QGIS koodin versio	`4a4b62e`
Käännetty käyttäen Qt:tä	5.11.2	Suoritetaan käyttäen QT:tä	5.11.2
Käännetty käyttäen GDAL/OGR:ia	2.3.2	Suoritetaan käyttäen GDAL/OGR:ia	2.3.2
Käännetty käyttäen GEOS	3.7.0-CAPI-1.11.0	Suoritetaan käyttäen GEOSia	3.7.0-CAPI-1.11.0 673b9939
PostgreSQL Client Versio	9.2.4	SpatiaLite-versio	4.3.0
QWT Versio	6.1.3	QScintilla2 Versio	2.10.8
Käännetty käyttäen PROJ:ia	520	Suoritetaan käyttäen PROJ:ia	5.2.0

< edit: It appears I was too hasty. QGIS crashed and now that I've restarted with en-GB it appears to be working. I'm good to go, I believe. I leave this here in case someone finds this useful. :)

elpaso · 2018-11-05T09:11:27Z

@veikkoeeva please file and issue and attach a sample project we can use to reproduce the issue.

Add options to override locale and number group sep.

9976fc2

Add preview for locale settings

13a727c

Omit group separator by default

217b851

Collect list of available locales instead of using

a092f56

... the translations available in QGIS.

nyalldawson added Bugfix Needs Backporting labels Jul 2, 2018

nyalldawson added this to the 3.4 milestone Jul 2, 2018

nyalldawson reviewed Jul 2, 2018

View reviewed changes

Fix QLocale bitwise operation and some other minor style issues

fd84f82

elpaso added 2 commits July 3, 2018 08:38

Re-use variable for current locale

f072485

Rename variable (code layout)

b1a67ba

elpaso merged commit 85da39a into qgis:master Jul 3, 2018

elpaso deleted the locale-options branch July 3, 2018 07:47

elpaso mentioned this pull request Jul 3, 2018

Locale options backport #7357

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add options to override locale and number group sep. #7337

Add options to override locale and number group sep. #7337

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

nyalldawson commented Jun 29, 2018

elpaso commented Jun 30, 2018

m-kuhn commented Jun 30, 2018 •

edited

Loading

jef-n commented Jun 30, 2018

elpaso commented Jul 2, 2018

andreasneumann commented Jul 2, 2018

elpaso commented Jul 2, 2018 •

edited

Loading

andreasneumann commented Jul 2, 2018

elpaso commented Jul 2, 2018 •

edited

Loading

nyalldawson Jul 2, 2018

nyalldawson Jul 2, 2018

nyalldawson Jul 2, 2018

nyalldawson Jul 2, 2018

veikkoeeva commented Nov 4, 2018 •

edited

Loading

elpaso commented Nov 5, 2018

Add options to override locale and number group sep. #7337

Add options to override locale and number group sep. #7337

Conversation

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

elpaso commented Jun 29, 2018

m-kuhn commented Jun 29, 2018

elpaso commented Jun 29, 2018

nyalldawson commented Jun 29, 2018

elpaso commented Jun 30, 2018

m-kuhn commented Jun 30, 2018 • edited Loading

jef-n commented Jun 30, 2018

elpaso commented Jul 2, 2018

andreasneumann commented Jul 2, 2018

elpaso commented Jul 2, 2018 • edited Loading

andreasneumann commented Jul 2, 2018

elpaso commented Jul 2, 2018 • edited Loading

nyalldawson Jul 2, 2018

Choose a reason for hiding this comment

nyalldawson Jul 2, 2018

Choose a reason for hiding this comment

nyalldawson Jul 2, 2018

Choose a reason for hiding this comment

nyalldawson Jul 2, 2018

Choose a reason for hiding this comment

veikkoeeva commented Nov 4, 2018 • edited Loading

elpaso commented Nov 5, 2018

m-kuhn commented Jun 30, 2018 •

edited

Loading

elpaso commented Jul 2, 2018 •

edited

Loading

elpaso commented Jul 2, 2018 •

edited

Loading

veikkoeeva commented Nov 4, 2018 •

edited

Loading