[2.18LTR] Fix field calculator in not able to add a new field #7375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cified length/width (this is the default in QgsField constructor and QgsVectorDataProvider::NativeType())
…precision against min/max if they are defined (ie > 0). Fixes test_qgsauxiliarystorage.py and qgis_projectstoragetest
|
failure seems unrelated to these changes. |
m-kuhn
changed the title
elpaso
approved these changes
Jul 13, 2018
| QgsDebugMsgLevel( QString( "field name = %1 type = %2 length = %3 precision = %4" ) | ||
| .arg( field.name(), | ||
| QVariant::typeToName( field.type() ) ) | ||
| .arg( field.length() ) | ||
| .arg( field.precision() ), 2 ); | ||
| for ( i = 0; i < mNativeTypes.size(); i++ ) | ||
| Q_FOREACH ( const NativeType &nativeType, mNativeTypes ) |
There was a problem hiding this comment.
can you use a range loop here?
There was a problem hiding this comment.
Oh, sorry, this is 2.18 forget my comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should to fix the regression issue #19283 raised since 033071a (which must not be reverted). The PR is basically a backport of 00c301e and e715b91.
Also, set 0 as default precision on field definition if not defined from the user in order to avoid to define precision for string or datetime type.
Commit 6e45069 can be applied to master branch too.
Sorry I cannot build a 2.18 branch on my machine right now so please test before merging (if it looks good to you).
Checklist
fixes #11111in the commit message next to the description[FEATURE]in the commit message[needs-docs]in the commit message and contain sufficient information in the commit message to be documentedscripts/prepare-commit.shscript before each commit