Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Improve 3D map scene config dialog #9082

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

nirvn
Copy link
Contributor

@nirvn nirvn commented Feb 4, 2019

Description

@wonder-sk , because my large screen couldn't even fit the 3d map scene config dialog anymore:
image

It's not ideal, but good enough to avoid documentation mess and backporting to 3.4. In 3.8, it might be worth re-thinking the dialog to use tabs, like labelling and mesh settings do. Have lights in its own tab, with a nice light icon, etc.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

  • Commit messages are descriptive and explain the rationale for changes
  • Commits which fix bugs include fixes #11111 in the commit message next to the description
  • Commits which add new features are tagged with [FEATURE] in the commit message
  • Commits which change the UI or existing user workflows are tagged with [needs-docs] in the commit message and contain sufficient information in the commit message to be documented
  • I have read the QGIS Coding Standards and this PR complies with them
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • New unit tests have been added for core changes
  • I have run the scripts/prepare-commit.sh script before each commit

@saberraz
Copy link
Contributor

saberraz commented Feb 4, 2019

Thanks @nirvn
You can mark this ticket as resolved in your commit:
https://issues.qgis.org/issues/20685

Copy link
Member

@wonder-sk wonder-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that! Agreed that later it should use tabs as the number of options is constantly increasing.

Also, one thing on my wish list is to be able to reuse Layer Styling dock for other purposes - such as 3D scene configuration or project properties

@nirvn nirvn merged commit 41a04d0 into qgis:master Feb 4, 2019
@DelazJ
Copy link
Contributor

DelazJ commented Feb 4, 2019

Thanks @nirvn
A help button leading to here or here would imho make the fix really complete (I checked but couldn't figure out where to add the changes so if anyone...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants