Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tabulate-counts action #151

Merged
merged 4 commits into from
Sep 27, 2023
Merged

add tabulate-counts action #151

merged 4 commits into from
Sep 27, 2023

Conversation

gregcaporaso
Copy link
Member

This adds a new action, tabulate-counts, which reads one or more demux artifacts and generates an ImmutableMetadata artifact with the per-sample sequence counts.

Fixes #150.

@wasade
Copy link
Member

wasade commented Sep 6, 2023

Seems good pending CI, this is super helpful to have!

@gregcaporaso
Copy link
Member Author

Thanks @wasade! These failures seem unrelated, so we'll get those sorted out independently of this PR.

@gregcaporaso
Copy link
Member Author

gregcaporaso commented Sep 7, 2023

I'm thinking a better name for this would be tabulate-reads tabulate-read-counts, since counts are really the outcome, not what's being tabulated. Converting this to a draft PR until I make a decision on that.

@gregcaporaso gregcaporaso marked this pull request as draft September 7, 2023 16:46
@gregcaporaso gregcaporaso marked this pull request as ready for review September 7, 2023 23:37
@gregcaporaso
Copy link
Member Author

Linting should pass after #152 is merged.

@Oddant1
Copy link
Member

Oddant1 commented Sep 27, 2023

@gregcaporaso I fixed the merge conflicts is this ready to merge?

@gregcaporaso
Copy link
Member Author

Yep, this is ready to go!

@gregcaporaso
Copy link
Member Author

I just added a note to the draft release notes on this one.

@Oddant1 Oddant1 merged commit 708a744 into qiime2:dev Sep 27, 2023
4 checks passed
@gregcaporaso gregcaporaso deleted the issue-150 branch September 27, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
3 participants