Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bioenv 0 variance filter #276

Merged
merged 5 commits into from
Jun 22, 2020

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Jun 9, 2020

closes #275

@andrewsanchez
Copy link
Contributor

This seems fine to me if jumping between QIIME 2 objects and pandas DataFrames is a common/acceptable pattern. Is that the case?

However, should we consider extending Metadata.filter_ids to handle stuff like this? Even so, I'm good with merging this now and handling opening another issue for that.

Co-authored-by: Chris Keefe <39198770+ChrisKeefe@users.noreply.github.com>
@thermokarst
Copy link
Contributor

This seems fine to me if jumping between QIIME 2 objects and pandas DataFrames is a common/acceptable pattern. Is that the case?

It isn't ideal, but its not a showstopper, in my opinion. I would love to see a new filter added to Metadata, though, that would be a sweet addition.

q2_diversity/_beta/_visualizer.py Outdated Show resolved Hide resolved
@andrewsanchez
Copy link
Contributor

This seems fine to me if jumping between QIIME 2 objects and pandas DataFrames is a common/acceptable pattern. Is that the case?

It isn't ideal, but its not a showstopper, in my opinion. I would love to see a new filter added to Metadata, though, that would be a sweet addition.

Cool, then I'll go ahead and merge this then open a new ENH issue on the framework about adding a new filter.

q2_diversity/_beta/_visualizer.py Outdated Show resolved Hide resolved
@andrewsanchez andrewsanchez merged commit 76e368f into qiime2:master Jun 22, 2020
@Oddant1 Oddant1 deleted the bioenv_0_variance_filter branch June 25, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bioenv fails if 0 variance columns are left after dropping rows with empty cells
4 participants