Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: PEDs/PEDS Associated Methods #101

Merged
merged 16 commits into from
Nov 8, 2024
Merged

Conversation

cherman2
Copy link
Contributor

@cherman2 cherman2 commented Sep 24, 2024

This PR majorly refactors PEDS Associated Methods to work like q2-boots.

  • Refactor Peds-sims to incorp boots (1d035f0)
  • refactor peds to be able to run boots (a649ea2)
  • refactor pprs to be able to run boots (423f44e)
  • move helper methods into utils (bd96ddb)
  • remove missing-timepoints filter and move to heatmap and not required(68bea7a)
  • remove missing subjects and move to heatmap and not required (68bea7a)
  • add usage example for heatmap (2508a65 and ceb45b8)
  • add usage example for peds (71a19d4 and eb26eb1)
  • use q2-stats json_replace(c46ad4f) (This commit also updates q2-fmt to be compatible with the new stats changes 🎉 )

closes #100
closes #85
closes #97
closes #94
closes #93

@cherman2 cherman2 self-assigned this Sep 26, 2024
@cherman2 cherman2 assigned gregcaporaso and ebolyen and unassigned cherman2 Oct 29, 2024
@cherman2 cherman2 removed the request for review from gregcaporaso October 29, 2024 19:18
q2_fmt/_util.py Outdated Show resolved Hide resolved
q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/_peds.py Outdated Show resolved Hide resolved
q2_fmt/_util.py Outdated Show resolved Hide resolved
q2_fmt/_util.py Outdated Show resolved Hide resolved
q2_fmt/_util.py Outdated Show resolved Hide resolved
q2_fmt/_util.py Outdated Show resolved Hide resolved
q2_fmt/_util.py Outdated Show resolved Hide resolved
@cherman2
Copy link
Contributor Author

cherman2 commented Nov 8, 2024

Alright! I think this is ready for your review again!
Again, Thank you for your time and review!

@ebolyen ebolyen merged commit ed022ec into qiime2:dev Nov 8, 2024
4 checks passed
@ebolyen ebolyen assigned cherman2 and unassigned ebolyen Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Changelog Needed
3 participants