Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sorting icons in index.html file #31

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Conversation

clawss
Copy link
Collaborator

@clawss clawss commented Dec 4, 2018

creating inline css to override css style sheet, associated with pull request #30

creating inline css to override css style sheet, associated with pull request qiime2#30
@thermokarst thermokarst mentioned this pull request Dec 4, 2018
@thermokarst thermokarst self-assigned this Dec 4, 2018
@thermokarst thermokarst self-requested a review December 4, 2018 17:38
Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clawss!! I just tried pulling down these changes, but I am not seeing any functional change in the rendering --- how does it look on your end? For example:

BEFORE:
image

AFTER:
image

I stewed on this a little bit, and maybe there is an easier solution out there:

https://datatables.net/examples/styling/bootstrap.html

We are already using Bootstrap 3 here in this viz, so I wonder if we drop the file referenced here and replace it with dataTables.bootstrap.min.css referenced in the datatables.net link (in the CSS tab at the bottom:

image
). I think then we get a) consistent bootstrap styling and b) good looking cell borders, which help clear up any confusion around the sorting icons. What do you think?

@thermokarst thermokarst assigned clawss and unassigned thermokarst Dec 8, 2018
@thermokarst
Copy link
Contributor

Hi there @clawss! Just wanted to follow up on this --- are you interested in continuing work on this? If so - great! We are here to help! If not, no worries! We can either close this PR, or, someone else could take over development of this fix. Please let us know how you would like to proceed! Thanks!

@clawss
Copy link
Collaborator Author

clawss commented Jan 23, 2019 via email

@thermokarst
Copy link
Contributor

Thanks for the update @clawss. Can you please provide some guidance on how you would like to proceed? I asked about a few options in my previous post --- we can either close this PR, or, pass it off to someone else (I can identify that person, just need your permission).

@clawss
Copy link
Collaborator Author

clawss commented Jan 23, 2019 via email

@thermokarst
Copy link
Contributor

No worries - thanks!

@thermokarst thermokarst assigned thermokarst and unassigned clawss Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants