-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating sorting icons in index.html file #31
Conversation
creating inline css to override css style sheet, associated with pull request qiime2#30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @clawss!! I just tried pulling down these changes, but I am not seeing any functional change in the rendering --- how does it look on your end? For example:
I stewed on this a little bit, and maybe there is an easier solution out there:
https://datatables.net/examples/styling/bootstrap.html
We are already using Bootstrap 3 here in this viz, so I wonder if we drop the file referenced here and replace it with dataTables.bootstrap.min.css
referenced in the datatables.net link (in the CSS tab at the bottom:
). I think then we get a) consistent bootstrap styling and b) good looking cell borders, which help clear up any confusion around the sorting icons. What do you think?
Hi there @clawss! Just wanted to follow up on this --- are you interested in continuing work on this? If so - great! We are here to help! If not, no worries! We can either close this PR, or, someone else could take over development of this fix. Please let us know how you would like to proceed! Thanks! |
Hi Matthew,
I would have loved to continue working on the project but unfortunately
with school picking up I’m going to have to step back.
Thank you for reaching out to me.
Claudia
On Wed, Jan 23, 2019 at 9:54 AM Matthew Dillon ***@***.***> wrote:
Hi there @clawss <https://github.com/clawss>! Just wanted to follow up on
this --- are you interested in continuing work on this? If so - great! We
are here to help! If not, no worries! We can either close this PR, or,
someone else could take over development of this fix. Please let us know
how you would like to proceed! Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWMATs-C_BM2bFxEA-rNsiqE7EnC7_CQks5vGJO3gaJpZM4ZA-oj>
.
--
|
Thanks for the update @clawss. Can you please provide some guidance on how you would like to proceed? I asked about a few options in my previous post --- we can either close this PR, or, pass it off to someone else (I can identify that person, just need your permission). |
My apologies, you can pass it off.
On Wed, Jan 23, 2019 at 4:10 PM Matthew Dillon ***@***.***> wrote:
Thanks for the update @clawss <https://github.com/clawss>. Can you please
provide some guidance on how you would like to proceed? I asked about a few
options in my previous post --- we can either close this PR, or, pass it
off to someone else (I can identify that person, just need your permission).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWMATkySPGQ1KqjgivLQKkWDX-7ETjIcks5vGOv9gaJpZM4ZA-oj>
.
--
Claudia Coronel
|
No worries - thanks! |
creating inline css to override css style sheet, associated with pull request #30