ENH: Adding in hierarchy type #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything else that is required here? This would be really nice for clarifying the semantics for tree types other than phylogenies in the future. |
|
I'm fine with this as written, but we'll need some transformers for it (it looks like your commit history may have gotten backwards, I see the AlphaDiversity stuff). Anyone else have thoughts here? |
|
Just a note that this resolves #99. |
|
Sorry we don't need transformers, I completely forgot how this worked when I wrote that comment. |
ebolyen
approved these changes
May 12, 2017
|
Thanks!
…On Fri, May 12, 2017 at 11:35 AM, Evan Bolyen ***@***.***> wrote:
Merged #112 <#112>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#112 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AD_a3Ruo-E7FjbCCCsooQZnScFLCxK0Mks5r5KaEgaJpZM4M3u6X>
.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for introducing another tree data type
Hierarchy.The main motivation behind this is there are other instances of trees other than
Phylogenysuch as hierarchical clusterings. And usingPhylogenyto represent these data types are incredibly misleading. This is critical for reducing confusion for performing analyses with Gneiss, which can operate directly onPhylogenyandHierarchytypes.