Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: removed use of deprecated method from_csv #228

Merged
merged 6 commits into from
Sep 6, 2019
Merged

MAINT: removed use of deprecated method from_csv #228

merged 6 commits into from
Sep 6, 2019

Conversation

David-Rod
Copy link
Contributor

@David-Rod David-Rod commented Sep 6, 2019

Pandas has deprecated the from_csv method in favor of read_csv as of v0.21.0. This change is needed to make plugins pass unit tests utilizing the newest version of pandas v0.25.1. Fixes issue #227

Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A few minor questions (looking for clarification on motivation), inline!

q2_types/sample_data/tests/test_transformer.py Outdated Show resolved Hide resolved
q2_types/sample_data/tests/test_transformer.py Outdated Show resolved Hide resolved
q2_types/sample_data/tests/test_transformer.py Outdated Show resolved Hide resolved
q2_types/sample_data/tests/test_transformer.py Outdated Show resolved Hide resolved
@thermokarst thermokarst merged commit 6dd5ec3 into qiime2:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants