Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HACK: Revert pin added in #233 #240

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Conversation

Oddant1
Copy link
Member

@Oddant1 Oddant1 commented Feb 13, 2020

closes #232, matplotlib 3.1.3 is producing correct heatmaps.
Selection_026

@Oddant1 Oddant1 closed this Feb 13, 2020
@Oddant1 Oddant1 changed the title HACK: Revert pin added in #164 HACK: Revert pin added in #233 Feb 13, 2020
@Oddant1 Oddant1 reopened this Feb 13, 2020
@Oddant1
Copy link
Member Author

Oddant1 commented Feb 13, 2020

Arg it's #233 not #164. 164 in sample-classifier is the issue this all originally stemmed from

Copy link
Contributor

@thermokarst thermokarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Oddant1!

BTW, I detailed out some steps on the conda resolution issues we ran into, here:

caporaso-lab/pretrained-feature-classifiers#6 (comment)

@thermokarst thermokarst merged commit f724e30 into qiime2:master Feb 14, 2020
@Oddant1 Oddant1 deleted the matplotlib-pin branch June 25, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move matplotlib pin to >=3.2
2 participants