-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMP: transformers SingleLanePerSample... to Casava #245
Conversation
Relevant discussion here: qiime2/q2-quality-control#52 I'm not sure yet about the transformer here https://github.com/qiime2/q2-types/pull/245/files#diff-3fd5d1462a2b3d80c0d3c98949f10949R94-R102 The problem is that it ends up producing a useless basepath, which ultimately needs to be rewritten in the format property. Perhaps it would be better to eliminate that transformer altogether and stick it all in the property, I was just trying to recycle as much of the transformers functionality as I possibly could. Open to ideas. |
The more I think about this, the more I want to refactor as internal utils used by the fmt property && the transformers, and dropping this transformer. |
Okay, the diff is pretty gross because there is a bit of code churn, but the refactor looks like this: first I moved all the utils out of |
BTW - this is still missing unit tests, but I can add those as part of my response-to-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thermokarst ! This LGTM, I just have one inline comment.
Fixes #209
Related to qiime2/q2-quality-control#52
Missing unit tests