-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMP: additional aligned sequence transformers #248
IMP: additional aligned sequence transformers #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed out of band with @gregcaporaso - unit tests will be added to exercise these new transformations.
with ff.open() as f: | ||
for id_, seq in data.iteritems(): | ||
sequence = skbio.DNA(seq, metadata={'id': id_}) | ||
skbio.io.write(sequence, format='fasta', into=f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block shows up more than once in this file - might be a good candidate for a util function.
Do we need an |
Discussed out of band with @thermokarst - we do already have that in this plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Magnifique!
This adds transformers needed for qiime2/q2-feature-table#232 and qiime2/q2-alignment#70