-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: qiime tools show-types and qiime tools show-formats commands #291
FEAT: qiime tools show-types and qiime tools show-formats commands #291
Conversation
…fferentiating between file and cache
Hey @colinvwood, I haven't reviewed this in any detail, but I think it's worth removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @colinvwood, I have some requests for changes on this PR. It might look like a lot, but they're all pretty minor so I think this should be relatively quick to address. Let me know if you have any questions.
Not sure why the cache test is failing, maybe @Oddant1 can weigh in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the updates @colinvwood!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Added two commands to show the available semantic types and importable and exportable formats for a qiime deployment.
Will replace the functionality of the
qiime tools import --show-importable-types
andqiime tools import --show-importable-formats
commands.Additionally:
--tsv
flag is availableMotivated by #289.