Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xrefs with bio.tools to XMLs #54

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

bebatut
Copy link
Contributor

@bebatut bebatut commented May 17, 2024

Hi,

This PR adds xrefs to XMLs with link to QIIME2 bio.tools entry: https://bio.tools/qiime2
It will be useful to get EDAM ontology annotations for the tool directly from bio.tools, e.g. for grouping tools by topics for the
new Galaxy tool panel.

It is the first time I look at this code so I hope I did not break anything 😅

Bérénice

@ebolyen
Copy link
Member

ebolyen commented May 30, 2024

Hey @bebatut! This looks pretty great. I'll put in our review board for our next release.

Copy link
Member

@ebolyen ebolyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo, but works great after fixing. Thanks @bebatut!

q2galaxy/core/templaters/common.py Outdated Show resolved Hide resolved
@ebolyen ebolyen merged commit 324442b into qiime2:dev Jun 13, 2024
4 checks passed
@ebolyen ebolyen removed their assignment Jun 13, 2024
@bebatut bebatut deleted the add_xrefs_to_xml branch June 14, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants