Transactionize the search engine and commands #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-1318-search-cmds
|
|
||
| return Study.create(User(owner), title, efo_ids, infodict) | ||
| return Study.create(User(owner), title, efo_ids, infodict) |
There was a problem hiding this comment.
should this return be outside the TRN? I guess it doesn't matter but rather ask ...
There was a problem hiding this comment.
Nope, that return is executing multiple access to the DB at different points: User(owner) and in Study.create.... Also, if something during the creation goes wrong, I want the entire transaction to rollback, so no modifications in the DB are performed (there are some StudyPerson.create above)
|
A few questions. |
|
@antgonza I think I've answered your questions and addressed your comments. |
|
@squirrelo can you review this one? |
|
👍 |
1 similar comment
|
👍 |
squirrelo
added a commit
that referenced
this pull request
Jul 7, 2015
Transactionize the search engine and commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered an issue with the Transaction object: it was always passing an empty list to psycopg2. This is not a problem unless we are passing
%chars in the SQL query, which are passed in the search engine for theLIKE-alike queries.I just added a small check in the Transaction object that instead of passing an empty list, it will pass None, which doesn't create any problem.