Transactionaize patches and environment mgr #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@antgonza @squirrelo this is ready for review. |
| 'SELECT f.* from qiita.filepath f JOIN qiita.analysis_filepath afp ON ' | ||
| 'f.filepath_id = afp.filepath_id') | ||
| # retrieve relative filepaths as dictionary for matching | ||
| mountpoints = {m[1].rstrip('/\\'): m[0] for m in get_mountpoint( |
|
👍 if tests pass |
|
errors were with my friend flake8 |
| @@ -101,18 +103,21 @@ def _add_ontology_data(conn): | |||
| raise IOError("Error: Could not fetch ontologies file from %s" % | |||
There was a problem hiding this comment.
This part should probably also be in the TRN, since it can fail and cause rollback.
There was a problem hiding this comment.
Not needed. If this is the first function, the transaction didn't even started. If another function inside a transaction is calling this, that other context will catch it and rollback.
|
few comments. |
|
@squirrelo comments answered |
|
👍 |
squirrelo
added a commit
that referenced
this pull request
Jul 7, 2015
Transactionaize patches and environment mgr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the patches and the environment manager to use transactions.
Few notes: