Transactionize QIITA-pet #1347
Merged
Transactionize QIITA-pet #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
AuthCreateHandler post method needs a decorator. Other then that, is good. |
|
@squirrelo can you merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I've changed a lot of files, I've been just decorating the functions that need to be executed as a transactions.
The files that I'm missing to transactionize are:
preprocessing_handlers.py
compute.py
vamps_handlers.py
ebi_handlers.py
analysis_handlers.py
The reason why is that they depend on Qiita-ware and we need to do some changes in qiita-ware, which we will talk on today's meeting.
Please test this in your local machines before merging.