Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public studies are being shown in the user own studies #2122

Merged
merged 3 commits into from
Apr 29, 2017

Conversation

antgonza
Copy link
Member

This fixes:

Note that these changes will make a lot of the tests fail but want to see which are they ...

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.929% when pulling 4ecff71 on antgonza:user-kept-public-study into b5c7fd5 on biocore:master.

@antgonza antgonza changed the title WIP: public studies are being shown in the user own studies public studies are being shown in the user own studies Apr 29, 2017
@antgonza
Copy link
Member Author

This is ready for review.

Copy link
Member

@ElDeveloper ElDeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, would be nice to expand the unit tests of _build_study_info to include 'sandbox' and 'private' studies, but it seems like this was not tested before anyways ¯\_(ツ)_/¯

@antgonza
Copy link
Member Author

Yup, there were no tests for this so added some. Note that we really only have 2 status or study lists: public and not public (user: sandbox, private) so they are being tested.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 91.94% when pulling 219f479 on antgonza:user-kept-public-study into b5c7fd5 on biocore:master.

@josenavas josenavas merged commit 50bfc4a into qiita-spots:master Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants