2022.07 #3206
Merged
2022.07 #3206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cowart
suggested changes
Jul 1, 2022
qiita_db/processing_job.py
Outdated
| self.command.name, self.id)) | ||
| message = ('New status: %s' % (new_status)) | ||
| qdb.util.send_email(self.user.email, subject, message) | ||
| if value not in ('waiting'): |
There was a problem hiding this comment.
since there's only one value, shouldn't it be if value != 'waiting'? Also, without a ',' this will come back as type str, according to the interpreter.
| ignore_commands = ('Validate', 'complete_job', | ||
| 'release_validators') | ||
| if self.command.name not in ignore_commands: | ||
| subject = 'Job status change: %s (%s)' % ( |
There was a problem hiding this comment.
I like to use %s myself when I have the choice. Just want to confirm that it's okay to use %s and not f'{}' in new code.
There was a problem hiding this comment.
Agreed this is a matter of preference and what works well for placating flake8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.