fix #3219 #3278
Merged
fix #3219 #3278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
antgonza
requested changes
May 22, 2023
INSTALL.md
Outdated
| @@ -20,7 +20,7 @@ Setup a virtual environment in conda named `qiita` by executing the following: | |||
|
|
|||
| ```bash | |||
| conda config --add channels conda-forge | |||
| conda create -q --yes -n qiita python=3.6 pip libgfortran numpy nginx | |||
| conda create -q --yes -n qiita python=3.9 pip libgfortran numpy nginx cython redis | |||
There was a problem hiding this comment.
Does this really need to change?
There was a problem hiding this comment.
I believe the change was to reflect what was being used in Github Workflows:
qiita_db/analysis.py
Outdated
| @@ -1102,12 +1102,14 @@ def _build_mapping_file(self, samples, rename_dup_samples=False, | |||
| if si not in sample_infos: | |||
| si_df = si.to_dataframe() | |||
| if categories is not None: | |||
| si_df = si_df[set(categories) & set(si_df.columns)] | |||
| si_df = si_df[list(set(categories) & | |||
There was a problem hiding this comment.
I think these changes are needed for pandas > 2.0, no?
antgonza
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my knowledge, this appears to fix the outstanding issue. Validation of the two required fields is handled by bootstrap and jinja2. Unselected pulldowns will now display a default tool-tip bubble.