Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose no_public to sample_template_checks #3290

Merged
merged 1 commit into from
May 26, 2023

Conversation

antgonza
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 16, 2023

Coverage Status

coverage: 92.928%. remained the same
when pulling b2fd1da on antgonza:sample_template_checks-no_public
into aac0ec7 on qiita-spots:dev.

@antgonza
Copy link
Member Author

Before this change, the "delete samples" function will create a new job that will fail like this:
before

Now, it will fail with this before creating the job:
after

@wasade
Copy link
Contributor

wasade commented May 16, 2023

Looks good!

@antgonza antgonza merged commit b39c7df into qiita-spots:dev May 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants