Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding test_db_sql #3405

Merged
merged 39 commits into from
May 7, 2024
Merged

adding test_db_sql #3405

merged 39 commits into from
May 7, 2024

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented May 7, 2024

No description provided.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything but one comment in the documentation looks good. I'm wondering if we can make it sound more palatable.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@charles-cowart charles-cowart merged commit 7c7600e into qiita-spots:dev May 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants