Resource Allocation data in Redis #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request should only contain changes with uploading data to redis. I accidentally commited some changes to qiita_pet here.
antgonza
requested changes
Aug 29, 2024
qiita_db/meta_util.py
Outdated
| from json import loads, dump, dumps | ||
|
|
||
| from qiita_db.util import create_nested_path | ||
| from qiita_db.util import create_nested_path, _retrieve_resource_data |
There was a problem hiding this comment.
If _retrieve_resource_data is going to be use outside of util, then it should not start with _, could you change?
qiita_db/meta_util.py
Outdated
| import qiita_db as qdb | ||
|
|
||
| # global constant list used in resource_allocation_page | ||
| columns = [ |
There was a problem hiding this comment.
Normally global variables are all upper case.
qiita_db/meta_util.py
Outdated
Comment on lines
560
to
570
| software_commands = dict() | ||
| for software in software_list: | ||
| sname = software.name | ||
| sversion = software.version | ||
| commands = software.commands | ||
| if sname not in software_commands: | ||
| software_commands[sname] = {} | ||
| if sversion not in software_commands[sname]: | ||
| software_commands[sname][sversion] = [] | ||
| for command in commands: | ||
| software_commands[sname][sversion].append(command.name) |
There was a problem hiding this comment.
This could be simplified with a defaultdict, could you check that?
antgonza
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.