changes for 2025.07 #3479
Merged
changes for 2025.07 #3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
commented
Jul 11, 2025
| @@ -482,12 +482,12 @@ def test_mark_messages(self): | |||
| user.mark_messages([1, 2]) | |||
| obs = user.messages() | |||
| exp = [True, True, False] | |||
| self.assertEqual([x[3] for x in obs], exp) | |||
| self.assertCountEqual([x[3] for x in obs], exp) | |||
There was a problem hiding this comment.
Note that this code hasn't changed in a long time; however, this failed during the last CI run due to different order. Thus, changing to assertCountEqual as it checks for values but not order.
antgonza
commented
Jul 11, 2025
| {% if creation_job_artifact_summary is not None %} | ||
| <a class="btn btn-default" target="_blank" href="{% raw qiita_config.portal_dir %}/artifact/html_summary/{{creation_job_artifact_summary}}"><span class="glyphicon glyphicon-download-alt"></span> Creation Job Output</a> | ||
|
|
||
| {% if editable and creation_job is not None and creation_job_artifact_summary is not None %} |
There was a problem hiding this comment.
This change to the html template is to support the results of the SPP new results Human Filter & QC existing Prep and partially address: #3477.
AmandaBirmingham
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.