Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 86 #94

Merged
merged 5 commits into from
Jun 18, 2014
Merged

Issue 86 #94

merged 5 commits into from
Jun 18, 2014

Conversation

josenavas
Copy link
Contributor

Fixes #86

Adds 2 new commands that will make developer's life easier:

  • clean_test_env: in case a unit test fails and the test db is dirty
  • drop_test_env: in case the settings table changes and need to rebuild the test env, this allows to drop the old one

@@ -62,6 +62,63 @@ def make_test_environment(base_data_dir, base_work_dir, user, password, host):
conn.close()


def clean_test_environment(user, password, host):
r"""Cleans the test database environment after a test failure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is not tied to a test failure really, it's where it will mainly be used but not tied. Would suggest changing this to Clean the test database environment.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.89%) when pulling 034cf32 on josenavas:issue_86 into d08c7dc on biocore:master.

@ElDeveloper
Copy link
Member

Looks good just one question/comment.

@josenavas
Copy link
Contributor Author

Thanks @ElDeveloper I've addressed your comments!

def clean_test_environment(user, password, host):
r"""Cleans the test database environment.

In case that the test database is dirty (i.e. the 'qiita' schema is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'qiita' -> 'qiita_test'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema is actually qiita. qiita_test is the database

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha!! If anyone +1s this, it should be ready to be merged.

On (Jun-17-14|20:36), josenavas wrote:

@@ -62,6 +62,63 @@ def make_test_environment(base_data_dir, base_work_dir, user, password, host):
conn.close()

+def clean_test_environment(user, password, host):

  • r"""Cleans the test database environment.
  • In case that the test database is dirty (i.e. the 'qiita' schema is

The schema is actually qiita. qiita_test is the database


Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/94/files#r13898318

@ElDeveloper
Copy link
Member

👍

teravest added a commit that referenced this pull request Jun 18, 2014
@teravest teravest merged commit cc3b832 into qiita-spots:master Jun 18, 2014
@josenavas josenavas deleted the issue_86 branch June 21, 2014 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add qiita_db delete_test_enviroment
4 participants