-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 86 #94
Issue 86 #94
Conversation
@@ -62,6 +62,63 @@ def make_test_environment(base_data_dir, base_work_dir, user, password, host): | |||
conn.close() | |||
|
|||
|
|||
def clean_test_environment(user, password, host): | |||
r"""Cleans the test database environment after a test failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not tied to a test failure really, it's where it will mainly be used but not tied. Would suggest changing this to Clean the test database environment
.
Looks good just one question/comment. |
Thanks @ElDeveloper I've addressed your comments! |
def clean_test_environment(user, password, host): | ||
r"""Cleans the test database environment. | ||
|
||
In case that the test database is dirty (i.e. the 'qiita' schema is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'qiita'
-> 'qiita_test'
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The schema is actually qiita
. qiita_test
is the database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha!! If anyone +1s this, it should be ready to be merged.
On (Jun-17-14|20:36), josenavas wrote:
@@ -62,6 +62,63 @@ def make_test_environment(base_data_dir, base_work_dir, user, password, host):
conn.close()+def clean_test_environment(user, password, host):
- r"""Cleans the test database environment.
- In case that the test database is dirty (i.e. the 'qiita' schema is
The schema is actually
qiita
.qiita_test
is the database
Reply to this email directly or view it on GitHub:
https://github.com/biocore/qiita/pull/94/files#r13898318
👍 |
Fixes #86
Adds 2 new commands that will make developer's life easier: