Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that we copy the input tree file vs. mv when creating a new biom #48

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

antgonza
Copy link
Member

No description provided.

@ElDeveloper
Copy link
Member

Looks good, is there an easy way to add a test?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 95.49% when pulling 3a100e6 on antgonza:fix-mv-input-tree into 2d19593 on qiita-spots:master.

@antgonza
Copy link
Member Author

"Easy", sadly AFAIK no. The issue is that we only have (1) a deblur table without tree and (2) a close reference table for testing. For (1) we would need to create a new tree, trim it down (to avoid size issues), add it to qiita (main qiita, not this plugin, which will represent changing a bunch of tests as this will be a new file in the system); then use it in test_feature_classifier to test these new lines. Then for (2) these new lines are not relevant.

@ElDeveloper ElDeveloper merged commit 825727e into qiita-spots:master Jan 22, 2020
@ElDeveloper
Copy link
Member

Thanks, I opened a separate ticket for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants