Add cloud SMS interface #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwifeng
reviewed
May 24, 2019
src/Qiniu/Sms/sms.php
Outdated
| $params['pics'] = $this->imgToBase64($pics); | ||
| } | ||
| $body = json_encode($params); | ||
| $url =$this->baseURL."signature"; |
rwifeng
reviewed
May 24, 2019
src/Qiniu/Http/Client.php
Outdated
| @@ -119,7 +126,13 @@ public static function sendRequest($request) | |||
| curl_close($ch); | |||
| return $r; | |||
| } | |||
| $curl_info = curl_getinfo($ch); | |||
| $header_size = $curl_info["header_size"]; | |||
| $body = substr($result, $header_size); | |||
rwifeng
reviewed
May 24, 2019
src/Qiniu/Http/Client.php
Outdated
| $code = curl_getinfo($ch, CURLINFO_HTTP_CODE); | ||
| if ($code != 200) { | ||
| throw new \Exception("\nhttpcode:".$code."\nmessage".$body); | ||
| } |
There was a problem hiding this comment.
php 这边没引入 Exception， 还是使用error 处理吧。
rwifeng
reviewed
May 24, 2019
src/Qiniu/Sms/sms.php
Outdated
| trade_name 商标名的全称或简称， | ||
| * pics: 本地的图片路径 string 类型，可选 | ||
| */ | ||
| public function createSignature($signature, $source, $pics = null) |
rwifeng
reviewed
May 24, 2019
src/Qiniu/Sms/sms.php
Outdated
| * audit_status: 审核状态 string 类型，可选， | ||
| 取值范围为: "passed"(通过), "rejected"(未通过), "reviewing"(审核中) | ||
| * page:页码 int 类型， | ||
| * maxUsers：人数限制 ，可选，默认为 1 |
rwifeng
reviewed
May 24, 2019
src/Qiniu/Sms/sms.php
Outdated
| $params['signature_id'] = $signture_id; | ||
|
|
||
| $body = json_encode($params); | ||
| var_dump($body); |
rwifeng
reviewed
May 24, 2019
src/Qiniu/Sms/sms.php
Outdated
|
|
||
| $body = json_encode($params); | ||
| var_dump($body); | ||
| $url =$this->baseURL."template"; |
rwifeng
reviewed
May 24, 2019
| 取值范围为: notification (通知类短信), verification (验证码短信), marketing (营销类短信) | ||
| * description: 申请理由简述 string 类型，必填 | ||
| * signature_id: 已经审核通过的签名 string 类型，必填 | ||
| */ |
rwifeng
reviewed
May 24, 2019
| 取值范围为: passed (通过), rejected (未通过), reviewing (审核中) | ||
| * page: 页码 int 类型，可选，默认为 1 | ||
| * page_size: 分页大小 int 类型，可选，默认为 20 | ||
| */ |
rwifeng
reviewed
May 24, 2019
src/Qiniu/Sms/sms.php
Outdated
| if ($fp) { | ||
| $filesize = filesize($app_img_file); | ||
| if ($filesize > 5*1024*1024) { | ||
| new Error("pic size < 5M !"); |
rwifeng
reviewed
May 24, 2019
| return array($ret->json(), null); | ||
| } | ||
|
|
||
| private function post($url, $body, $contentType = 'application/json') |
There was a problem hiding this comment.
@方兴看下这个是否要重构下， 不能每个class 都要封装一次 post/get 。。 等方法
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.