Skip to content

Conversation

timhbw
Copy link
Contributor

@timhbw timhbw commented Aug 21, 2020

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #341 into master will increase coverage by 25.10%.
The diff coverage is 64.10%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #341       +/-   ##
===========================================
+ Coverage   60.09%   85.19%   +25.10%     
===========================================
  Files          20       20               
  Lines        1268     1304       +36     
===========================================
+ Hits          762     1111      +349     
+ Misses        506      193      -313     
Impacted Files Coverage Δ
src/Qiniu/Auth.php 85.18% <ø> (+24.69%) ⬆️
src/Qiniu/Config.php 62.50% <ø> (+7.81%) ⬆️
tests/bootstrap.php 100.00% <ø> (ø)
src/Qiniu/Storage/BucketManager.php 77.41% <63.15%> (+42.49%) ⬆️
src/Qiniu/Http/Response.php 74.50% <100.00%> (ø)
src/Qiniu/Http/Client.php 100.00% <0.00%> (+6.38%) ⬆️
src/Qiniu/Http/Error.php 100.00% <0.00%> (+22.22%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c21f6...2fe9de0. Read the comment docs.

Copy link
Contributor

@longbai longbai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timhbw timhbw requested a review from longbai August 21, 2020 11:24
@timhbw timhbw marked this pull request as draft August 21, 2020 11:28
@timhbw timhbw marked this pull request as ready for review August 21, 2020 11:29
@longbai longbai merged commit 0af6cb2 into master Aug 21, 2020
@timhbw timhbw mentioned this pull request Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Response的isJson不支持http2的返回头 没有内容审核的sdk吗? 为什么不把某些接口加进来?
3 participants