Skip to content

Conversation

bachue
Copy link
Contributor

@bachue bachue commented Sep 23, 2021

No description provided.

@bachue bachue force-pushed the fix/resumable-upload-v2 branch from 6a93361 to 511985b Compare September 23, 2021 09:48
@qiniu-bot qiniu-bot added size/M and removed size/S labels Sep 23, 2021
@bachue bachue force-pushed the fix/resumable-upload-v2 branch 3 times, most recently from 5f5398c to 3e676e1 Compare September 23, 2021 10:23
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #362 (fe63159) into master (1c6bc89) will increase coverage by 1.08%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   86.79%   87.87%   +1.08%     
==========================================
  Files          20       20              
  Lines        1446     1476      +30     
==========================================
+ Hits         1255     1297      +42     
+ Misses        191      179      -12     
Impacted Files Coverage Δ
src/Qiniu/Http/Client.php 100.00% <ø> (ø)
src/Qiniu/Storage/UploadManager.php 96.55% <ø> (+12.06%) ⬆️
tests/bootstrap.php 92.85% <87.50%> (-7.15%) ⬇️
src/Qiniu/Storage/ResumeUploader.php 77.33% <92.00%> (+3.06%) ⬆️
src/Qiniu/Http/Response.php 76.36% <100.00%> (+1.85%) ⬆️
src/Qiniu/Storage/FormUploader.php 78.57% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1fae5...fe63159. Read the comment docs.

@bachue bachue force-pushed the fix/resumable-upload-v2 branch from 3e676e1 to f59acd9 Compare September 23, 2021 11:14
@qiniu-bot qiniu-bot added size/L and removed size/M labels Sep 24, 2021
@bachue bachue force-pushed the fix/resumable-upload-v2 branch from 579c3d1 to fe63159 Compare September 24, 2021 06:29
Copy link
Collaborator

@lihsai0 lihsai0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试用例 random 的原因?

GET URL 的时候,这些 URL 后面是有 CDN 的,如果先前上传了一个 key 的文件并且获取过,接下来对这个 key 的文件进行覆盖上传,再获取的时候,CDN 会返回先前缓存的文件内容,造成测试用例失败。

@xwen-winnie xwen-winnie merged commit 8fabdc0 into master Sep 24, 2021
@bachue bachue deleted the fix/resumable-upload-v2 branch September 24, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants