Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make compatible with php 8.x and fix compatible with php 5.3 #405

Merged
merged 9 commits into from May 6, 2023

Conversation

lihsai0
Copy link
Collaborator

@lihsai0 lihsai0 commented Apr 13, 2023

@lihsai0 lihsai0 force-pushed the features/compatible-php-8.x branch from 9123a1d to b7a6473 Compare April 17, 2023 03:16
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #405 (3db208b) into master (af52094) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 3db208b differs from pull request most recent head 605f852. Consider uploading reports for the commit 605f852 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
- Coverage   85.93%   85.47%   -0.46%     
==========================================
  Files          23       23              
  Lines        1849     1825      -24     
==========================================
- Hits         1589     1560      -29     
- Misses        260      265       +5     
Impacted Files Coverage Δ
src/Qiniu/Storage/BucketManager.php 91.40% <ø> (-0.03%) ⬇️
src/Qiniu/Enum/QiniuEnum.php 100.00% <100.00%> (ø)
src/Qiniu/Http/Header.php 100.00% <100.00%> (ø)
src/Qiniu/functions.php 90.00% <100.00%> (+0.71%) ⬆️

... and 6 files with indirect coverage changes

@bachue bachue merged commit 3c0ebee into master May 6, 2023
12 checks passed
@bachue bachue deleted the features/compatible-php-8.x branch May 6, 2023 04:36
@lihsai0 lihsai0 mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants