新版分片上传 #391
Merged
新版分片上传 #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachue
reviewed
May 18, 2021
bachue
suggested changes
May 18, 2021
okbang9
force-pushed
the
features/resumable-upload-v2
branch
from
5542676 to
e112a2e
Compare
bachue
reviewed
May 19, 2021
.idea/.gitignore
Outdated
| /dataSources/ | ||
| /dataSources.local.xml | ||
| # Editor-based HTTP Client requests | ||
| /httpRequests/ |
bachue
reviewed
May 19, 2021
test_qiniu.py
Outdated
| ret, info = put_stream(token, key, input_stream, os.path.basename(__file__), size, hostscache_dir, | ||
| self.params, | ||
| self.mime_type, part_size=1024 * 1024 * 10, version='v2', bucket_name=bucket_name) | ||
| print("\n\n\n\n\n", info) |
Codecov Report
@@ Coverage Diff @@
## master #391 +/- ##
==========================================
+ Coverage 66.22% 67.78% +1.56%
==========================================
Files 20 20
Lines 1723 1847 +124
==========================================
+ Hits 1141 1252 +111
- Misses 582 595 +13
Continue to review full report at Codecov.
|
bachue
reviewed
May 19, 2021
qiniu/services/storage/uploader.py
Outdated
| return record['offset'] | ||
|
|
||
| def upload(self): | ||
| def upload(self, metadata=None): |
There was a problem hiding this comment.
@okbang9 这个 metadata 先不要罢，v1 其实也有这个参数，但是这个 sdk 也没支持，所以先去掉。
bachue
reviewed
May 19, 2021
venv/pyvenv.cfg
Outdated
| @@ -0,0 +1,3 @@ | |||
| home = /usr/local/bin | |||
bachue
reviewed
May 19, 2021
qiniu/services/storage/uploader.py
Outdated
| if ret is None or crc != ret['crc32']: | ||
| return ret, info | ||
| if self.version == 'v1': | ||
| if info.need_retry(): |
There was a problem hiding this comment.
@okbang9 v1 的 crc32 验证不能去掉啊
bachue
reviewed
May 19, 2021
qiniu/services/storage/uploader.py
Outdated
| def block_url(self, host, size): | ||
| return '{0}/mkblk/{1}'.format(host, size) | ||
|
|
||
| def block_url_v2(self, host, bucket_name): | ||
| encode_object_name = urlsafe_base64_encode(self.key) if self.key is not None else '～' |
There was a problem hiding this comment.
@okbang9 encode_object_name => encoded_object_name
bachue
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.