Skip to content

Conversation

bachue
Copy link
Contributor

@bachue bachue commented Apr 14, 2021

变更背景描述

Qshell 使用 qnupload 和 qnupload2 上传多个文件时,因为复用 putPolicy,在 qiniu/go-sdk v7.9.2 及其之前的版本里,如果 putPolicy 被多次调用 UploadToken 方法签发,则签发的 Upload Token 的 deadline 不会随着时间的推移而改动。需要修复这个问题。

jira issue链接

https://jira.qiniu.io/browse/KODO-11993

主要变更点

  • fix bug
  • new feature
  • 不兼容变更

Checklist

  • 已自测
  • 已更新Readme

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #304 (ecba09a) into master (bf7a6a0) will not change coverage.
The diff coverage is n/a.

❗ Current head ecba09a differs from pull request most recent head 4c29874. Consider uploading reports for the commit 4c29874 to get more accurate results
Impacted file tree graph

@@          Coverage Diff           @@
##           master    #304   +/-   ##
======================================
  Coverage    6.31%   6.31%           
======================================
  Files          40      40           
  Lines        4594    4594           
======================================
  Hits          290     290           
  Misses       4299    4299           
  Partials        5       5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7a6a0...4c29874. Read the comment docs.

Copy link
Collaborator

@sxci sxci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@sxci sxci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bachue, sxci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Mei-Zhao Mei-Zhao merged commit c7957ca into master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants