Suppress numpy warning during uarray creation #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will eliminate the remaining warnings issued by sphinx when building the docs in #983 and so allow us to use |
|
This looks good to me but I want @nkanazawa1989 to have the chance to look it over too. |
coruscating
approved these changes
Mar 9, 2023
Merged
wshanks
added a commit
to wshanks/qiskit-experiments
that referenced
this pull request
Dec 20, 2023
This PR is a follow up to qiskit-community#1070. It suppresses numpy warnings during uncertainties array creation in more places in the code. Something changed recently in the numpy code so that it generates warnings when it used to suppress them, in particular when using `numpy.vectorize` which wraps user-level Python code inside of numpy C code and seems to lose context about warning state. See numpy/numpy#21416 for more information.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
This PR is a follow up to #1070. It suppresses numpy warnings during uncertainties array creation in more places in the code. Something changed recently in the numpy code so that it generates warnings when it used to suppress them, in particular when using `numpy.vectorize` which wraps user-level Python code inside of numpy C code and seems to lose context about warning state. See numpy/numpy#21416 for more information.
nkanazawa1989
pushed a commit
to nkanazawa1989/qiskit-experiments
that referenced
this pull request
Jan 17, 2024
This PR is a follow up to qiskit-community#1070. It suppresses numpy warnings during uncertainties array creation in more places in the code. Something changed recently in the numpy code so that it generates warnings when it used to suppress them, in particular when using `numpy.vectorize` which wraps user-level Python code inside of numpy C code and seems to lose context about warning state. See numpy/numpy#21416 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress invalid value warning from numpy during data processing
When handling level one data, DataProcessor would produce a numpy warning about
an invalid value. Briefly, the reason the warning is emitted is that
uncertaintiescallsnumpy.vectorizewhich callsuncertainties.core.Variablefrom within numpy C extension code.Variabledoes a
std_dev < 0check andDataProcessorsetsstd_devinitially tonan. When the CPU does a floating point comparison withnan, it sets anexception flag. Python ignores this flag, but numpy emits a warning, so when
Variableis created from within the numpy C code the warning is detected andemitted. As we know this chain of events will happen, we can simply ignore the
warning for this operation.