Skip to content

Conversation

eggerdj
Copy link
Contributor

@eggerdj eggerdj commented Jun 14, 2023

Summary

The variables __drive_freq_parameter__ and __readout_freq_parameter__ have been removed from Calibrations.

Details and comments

  • Why this change was necessary: These frequency variables were given special treatment which is inconsistent with the framework. Furthermore, this way of handling variables that do not have a schedule was not scalable.

  • What alternative solutions were considered and why the current solution was chosen: To replace them a mechanism to define and add parameters without a schedule has been added to the basis gate library. This has the benefit of making the API of frequency calibration experiments consistent with the other calibration experiments. Furthermore, the proposed change is scalable in that users can add more parameters that do not have a schedule to a library.

  • What tests and documentation have been added/updated: A test was added to make sure that users can add parameters.

  • What do users and developers need to know about this change: Users can now add parameters to their library that are not attached to a schedule in a meaningful way. The variables __drive_freq_parameter__ and __readout_freq_parameter__ have been removed from Calibrations.

eggerdj and others added 28 commits April 29, 2022 14:55
@nkanazawa1989 nkanazawa1989 self-assigned this Jun 18, 2023
Copy link
Collaborator

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel. I like this change. This will make it easy to define new gate library of, for example, qudit calibration where anharmonicity is necessary in addition to drive_freq. This approach looks good, but I also want to minimize new public attributes to reduce future maintenance overhead.

eggerdj and others added 2 commits June 19, 2023 13:45
@nkanazawa1989 nkanazawa1989 enabled auto-merge June 20, 2023 09:51
@nkanazawa1989 nkanazawa1989 added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@eggerdj eggerdj added this pull request to the merge queue Jun 20, 2023
@eggerdj eggerdj removed this pull request from the merge queue due to a manual request Jun 20, 2023
@eggerdj eggerdj added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2023
@eggerdj eggerdj added this pull request to the merge queue Jun 20, 2023
Merged via the queue into qiskit-community:main with commit fd21740 Jun 20, 2023
@eggerdj eggerdj mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants