-
Notifications
You must be signed in to change notification settings - Fork 131
Remove reserved variables #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Daniel. I like this change. This will make it easy to define new gate library of, for example, qudit calibration where anharmonicity is necessary in addition to drive_freq. This approach looks good, but I also want to minimize new public attributes to reduce future maintenance overhead.
qiskit_experiments/calibration_management/basis_gate_library.py
Outdated
Show resolved
Hide resolved
releasenotes/notes/params_without_schedule-20555d98875a626b.yaml
Outdated
Show resolved
Hide resolved
releasenotes/notes/params_without_schedule-20555d98875a626b.yaml
Outdated
Show resolved
Hide resolved
qiskit_experiments/calibration_management/basis_gate_library.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
Summary
The variables
__drive_freq_parameter__
and__readout_freq_parameter__
have been removed fromCalibrations
.Details and comments
Why this change was necessary: These frequency variables were given special treatment which is inconsistent with the framework. Furthermore, this way of handling variables that do not have a schedule was not scalable.
What alternative solutions were considered and why the current solution was chosen: To replace them a mechanism to define and add parameters without a schedule has been added to the basis gate library. This has the benefit of making the API of frequency calibration experiments consistent with the other calibration experiments. Furthermore, the proposed change is scalable in that users can add more parameters that do not have a schedule to a library.
What tests and documentation have been added/updated: A test was added to make sure that users can add parameters.
What do users and developers need to know about this change: Users can now add parameters to their library that are not attached to a schedule in a meaningful way. The variables
__drive_freq_parameter__
and__readout_freq_parameter__
have been removed fromCalibrations
.