-
Notifications
You must be signed in to change notification settings - Fork 131
Fix batch experiment calibrations #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ments into fix-batch-spec
The basic change here looks good to me outside of the |
Can we add a test for this? I.e. setup a batch experiment with e.g. two cal experiments and check that calibrations are there? |
This bug seems to not be due to calibrations, because it's been solved by #667. I will open another PR for adding tests. |
I think the issue might still be calibrations but #667 changed the way batch experiments' circuits are handled. Now the individual experiments are transpiled before the qubits are remapped into a new circuit. Before #667, the qubits were remapped before transpilation. My guess is that transpilation embeds the calibrations into the circuit so that they don't get lost in the remapping step, but I have not checked this. |
When a bug gets unexpectedly fixed, it still remains in the status of a bug until we fully understand how it was fixed, and are convinced that there are no cases where the bug can still occur. |
Summary
Closes #631. Copies over calibrations when constructing batch experiment from children, like parallel experiments do.