Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various docs changes for CI #253

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Various docs changes for CI #253

merged 1 commit into from
Apr 11, 2023

Conversation

woodsp-ibm
Copy link
Member

Summary

See qiskit-community/qiskit-nature#1109 for more detail.

Basically does the same three things

  • Removes dependency on sphinx-autodoc-typehints
  • Adds default thumbnail config as that changed in nbsphinx 0.9
  • Updates tox.ini gettext section used for translatable strings due to ipykernel not being installed by default now

Details and comments

@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented Apr 6, 2023 •
edited
Loading

CI here is failing, on 3.8 and above, in tests with yfinance, since these jobs pull in a newly released pandas 2.0.0 (3.7 is not supported by the new pandas so the 3.7 job pulls in an older one and passes). I can reproduce locally running the single unit test and switching pandas version.

See /ranaroussi/yfinance#1478

I leave this open for now - if a fix does not appear in the near future I will just pin pandas in CI

Update: Fixed in yfinance 0.2.17

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4622765022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.793%
Totals Coverage Status
Change from base Build 4496314069: 0.0%
Covered Lines: 645
Relevant Lines: 851
💛 - Coveralls

@woodsp-ibm woodsp-ibm added stable backport potential The bug might be minimal and/or import enough to be port to stable type: documentation Issues related to documentation automerge type: ci Related to CI changes labels Apr 11, 2023
@mergify mergify bot merged commit dd2ad0d into qiskit-community:main Apr 11, 2023
@woodsp-ibm woodsp-ibm deleted the ci_docs branch April 11, 2023 16:04
mergify bot pushed a commit that referenced this pull request Apr 11, 2023
@woodsp-ibm @mergify
Various docs changes for CI (#253)
4c4ea6e 
(cherry picked from commit dd2ad0d)

# Conflicts:
#	requirements-dev.txt
@mergify mergify bot mentioned this pull request Apr 11, 2023
Merged
woodsp-ibm added a commit that referenced this pull request Apr 11, 2023
@mergify @woodsp-ibm
Various docs changes for CI (backport #253) (#255)
803dfec 
* Various docs changes for CI (#253)

(cherry picked from commit dd2ad0d)

# Conflicts:
#	requirements-dev.txt

* Update requirements-dev.txt

Fix conflict

---------

Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-woerner stefan-woerner stefan-woerner approved these changes

@t-imamichi t-imamichi Awaiting requested review from t-imamichi t-imamichi is a code owner

Assignees
No one assigned
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes type: documentation Issues related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodsp-ibm @coveralls @stefan-woerner