Modified test_qsvr.py and test_fidelity_quantum_kernel_qsvr.py files for regression tasks #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have changed the dataset and the code to work for regression tasks.
rockywick
requested review from
woodsp-ibm,
adekusar-drl,
smens,
edoaltamura,
oscar-wallis,
OkuyanBoga and
Benjamin-Symons
as code owners
|
|
The files have been updated to correct the previous errors
Pull Request Test Coverage Report for Build 13886521511Details
💛 - Coveralls |
edoaltamura
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
Thanks for the PR @rockywick! The code looks good to go. Let's keep the discussion about the two unit tests being almost identical open in the issue though.
edoaltamura
added
type: enhancement ✨
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is regarding the issue #434
Details and comments
I have replaced the dataset used to a regression dataset and have modified the code to work for regression testing.
Result
Closes #434