Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the minimum version of Qiskit Terra #465

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

t-imamichi
Copy link
Collaborator

Summary

Qiskit optimization requires Terra 0.22.4 that includes various fixes of sampling-based algorithms https://github.com/Qiskit/qiskit-terra/releases/tag/0.22.4 to run the tutorials properly.

Details and comments

@coveralls
Copy link

coveralls commented Jan 23, 2023

Pull Request Test Coverage Report for Build 3992869754

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.065%

Totals Coverage Status
Change from base Build 3992246483: 0.0%
Covered Lines: 4339
Relevant Lines: 4713

💛 - Coveralls

@manoelmarques
Copy link
Contributor

manoelmarques commented Jan 23, 2023

Terra 0.23.0rc1 has already been released and 0.23 is almost out. Why not require `>=0.23.*' ? This way it won't lose the ability to be installed with Terra RC's.

@woodsp-ibm woodsp-ibm added this to the 0.5.0 milestone Jan 23, 2023
@t-imamichi
Copy link
Collaborator Author

I made this PR because the updated tutorials require terra 0.22.4. 0.23.* would work fine too. I don't have a strong opinion. >=0.22.4 allows users to use 0.22 while >=0.23.* forces to upgrade to 0.23.

@manoelmarques
Copy link
Contributor

manoelmarques commented Jan 24, 2023

In the end RC releases are meant to be used to verify if Terra still has bugs before the final release. End users should be working with the final releases and not RC. If someone wants to use a Terra RC release, one can just install it. Having >= 0.22.4 more accurately describes the minimum version required.

@t-imamichi
Copy link
Collaborator Author

Thank you for your information. I then merge this PR.

@mergify mergify bot merged commit 72e4794 into qiskit-community:main Jan 24, 2023
@t-imamichi t-imamichi deleted the requirements branch January 24, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants