New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompareVersion Solution Added #50
Conversation
Hi @Deeeeksha |
python/165_CompareVersion.py
Outdated
@@ -0,0 +1,30 @@ | |||
class Solution: | |||
def CompareVersion(self, version1: str, version2: str) -> int: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to compareVersion
to avoid submission error
python/165_CompareVersion.py
Outdated
for i in range(a-b): | ||
l2.append("0") | ||
|
||
if b>a: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this if can be change to else.
Thankyou @qiyuangong I will make the changes as requested. |
Hello @qiyuangong. Please review the changes requested as I have updated the code. |
Hello @qiyuangong , Any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thankyou @qiyuangong . |
You are welcome :) Thank you for your contribution! |
Hi @qiyuangong I have added CompareVersion Solution . KIndly review the changes