Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove nep5 contract pending data #1201

Merged
merged 4 commits into from
Jul 27, 2020
Merged

fix: remove nep5 contract pending data #1201

merged 4 commits into from
Jul 27, 2020

Conversation

zengchen221
Copy link
Contributor

@zengchen221 zengchen221 commented Jul 27, 2020

Proposed changes in this pull request

  • remove nep5 contract pending data
  • fix pov pub/sub

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

Goren G and others added 4 commits July 24, 2020 14:53
Signed-off-by: Goren G <yong.gu@qlink.mobi>
- format code

Signed-off-by: Goren G <yong.gu@qlink.mobi>
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #1201 into master will decrease coverage by 0.09%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1201      +/-   ##
==========================================
- Coverage   71.28%   71.18%   -0.10%     
==========================================
  Files         328      328              
  Lines       41216    41223       +7     
==========================================
- Hits        29381    29345      -36     
- Misses       7909     7934      +25     
- Partials     3926     3944      +18     
Flag Coverage Δ
#unittests 71.18% <10.52%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/kyc.go 86.57% <ø> (ø)
rpc/api/pov_pubsub.go 69.31% <ø> (ø)
vm/contract/abi/abi_kyc.go 73.97% <ø> (ø)
vm/contract/abi/abi_kyc_types.go 100.00% <ø> (ø)
vm/contract/kyc.go 79.80% <ø> (ø)
vm/contract/nep5_pledge.go 57.32% <0.00%> (-1.77%) ⬇️
ledger/migration/migration.go 64.12% <11.11%> (-4.05%) ⬇️
common/time.go 69.04% <0.00%> (-9.53%) ⬇️
consensus/pov/pov_sync_pool.go 61.99% <0.00%> (-3.62%) ⬇️
p2p/stream.go 71.59% <0.00%> (-2.96%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389227a...cd616f0. Read the comment docs.

Copy link
Contributor

@gythialy gythialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gythialy gythialy merged commit 6c2c460 into master Jul 27, 2020
@mergify mergify bot deleted the hotfix/nep5-pending branch July 27, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-rebase-and-merge ready-to-rebase-and-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants