Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config to adjust unchecked flush interval #1297

Merged
merged 4 commits into from
Dec 24, 2020

Conversation

zengchen221
Copy link
Contributor

Proposed changes in this pull request

  • config to adjust unchecked flush interval

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #1297 (518ef2c) into master (f87d47d) will decrease coverage by 0.03%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
- Coverage   68.58%   68.55%   -0.04%     
==========================================
  Files         329      329              
  Lines       36696    36726      +30     
==========================================
+ Hits        25169    25177       +8     
- Misses       7604     7624      +20     
- Partials     3923     3925       +2     
Flag Coverage Δ
unittests 68.55% <72.41%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ledger/ledger_uncheck.go 51.64% <55.88%> (+0.46%) ⬆️
ledger/ledger.go 64.96% <93.33%> (+0.46%) ⬆️
config/config_v10_testnet.go 100.00% <100.00%> (ø)
ledger/cache.go 77.77% <100.00%> (+0.08%) ⬆️
rpc/api/ledger.go 62.02% <100.00%> (ø)
consensus/dpos/processor.go 57.50% <0.00%> (-1.20%) ⬇️
p2p/sync.go 60.15% <0.00%> (-0.80%) ⬇️
consensus/pov/pov_sync.go 57.92% <0.00%> (-0.55%) ⬇️
consensus/pov/pov_chain.go 59.88% <0.00%> (-0.28%) ⬇️
consensus/dpos/dpos_impl_testnet.go 68.46% <0.00%> (-0.14%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87d47d...518ef2c. Read the comment docs.

@gythialy gythialy merged commit 27a2354 into master Dec 24, 2020
@mergify mergify bot deleted the feature/interval-config branch December 24, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-rebase-and-merge ready-to-rebase-and-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants