Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement spinlock #334

Merged
merged 1 commit into from
May 16, 2019
Merged

feat: implement spinlock #334

merged 1 commit into from
May 16, 2019

Conversation

gythialy
Copy link
Contributor

  • refine sync structure
  • add spin lock

Signed-off-by: Goren G yong.gu@qlink.mobi

Proposed changes in this pull request

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

- refine sync structure
- add spin lock

Signed-off-by: Goren G <yong.gu@qlink.mobi>
@gythialy gythialy added this to the v1.2.0 milestone May 16, 2019
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #334 into master will decrease coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
- Coverage   44.96%   44.91%   -0.05%     
==========================================
  Files         161      162       +1     
  Lines       16147    16158      +11     
==========================================
- Hits         7260     7258       -2     
- Misses       7757     7768      +11     
- Partials     1130     1132       +2
Impacted Files Coverage Δ
common/sync/hashmap/list.go 80.89% <ø> (ø)
trie/node_pool.go 33.33% <ø> (ø) ⬆️
common/sync/hashmap/hashmap.go 95.81% <ø> (ø)
common/sync/hashmap/util.go 100% <ø> (ø)
common/sync/hashmap/listelement.go 100% <ø> (ø)
vm/vmstore/vm_store.go 55.29% <ø> (ø) ⬆️
common/sync/hashmap/hashmap_get.go 91.3% <ø> (ø)
common/event/event_bus_impl.go 95.28% <100%> (ø) ⬆️
common/sync/spinlock/spinlock.go 63.63% <63.63%> (ø)
p2p/bootstrap.go 66.66% <0%> (-27.28%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d7a1e...9769422. Read the comment docs.

@gythialy gythialy merged commit d7f1e9c into master May 16, 2019
@gythialy gythialy deleted the feature/spinlock branch May 20, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants