Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/log #87

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Feature/log #87

merged 2 commits into from
Jan 15, 2019

Conversation

wenchaopeng
Copy link
Contributor

Proposed changes in this pull request

Explain the changes in this pull request in order to help the project maintainers understand the overall impact of it.

Please put an x against the checkboxes.

Type

  • Bug fix: (Link to the issue #{issue No.})
  • Feature (Non-breaking change)
  • Feature (Breaking change)
  • Documentation Improvement

Checklist

Write a small comment explaining if its N/A (not applicable)

  • Read the CONTRIBUTION.
  • All the tests are passing after the introduction of new changes.
  • Added tests respective to the part of code I have written.
  • Added proper documentation where ever applicable.
  • Code has been written according to Golang-Style-Guide

Extra information

Any extra information related to this pull request.

Signed-off-by: wenchao <659672152@qq.com>
@wenchaopeng wenchaopeng added this to the v1.0.0 milestone Jan 15, 2019
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #87 into master will decrease coverage by 0.01%.
The diff coverage is 25.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage      48%   47.99%   -0.02%     
==========================================
  Files          85       85              
  Lines        8016     7972      -44     
==========================================
- Hits         3848     3826      -22     
+ Misses       3449     3428      -21     
+ Partials      719      718       -1
Impacted Files Coverage Δ
consensus/utils.go 100% <ø> (+33.33%) ⬆️
rpc/ipc.go 100% <ø> (ø) ⬆️
rpc/types.go 91.3% <ø> (ø) ⬆️
p2p/events.go 80% <ø> (+7.27%) ⬆️
rpc/websocket.go 49.58% <ø> (+1.52%) ⬆️
p2p/message.go 70.12% <ø> (+2.62%) ⬆️
rpc/inproc.go 100% <ø> (ø) ⬆️
rpc/http.go 56.11% <ø> (-1.82%) ⬇️
rpc/client.go 44.87% <ø> (-0.11%) ⬇️
rpc/ipc_unix.go 63.63% <ø> (-3.04%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6e824...6410937. Read the comment docs.

@gythialy gythialy merged commit 96cc594 into master Jan 15, 2019
@wenchaopeng wenchaopeng deleted the feature/log branch January 16, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants