test: adding some more rendering tests for listbox #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pernyl
changed the title
johanlahti
reviewed
Mar 28, 2023
| @@ -15,6 +15,7 @@ | |||
| const app = { | |||
| id: `${+new Date()}`, | |||
| session: {}, | |||
| evaluateEx: async () => (fixture ? fixture.evaluateEx() : null), | |||
There was a problem hiding this comment.
For adding the histogram when dimension is not a field but a Master dimension
johanlahti
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding more rendering tests for listbox.
Covering different properties set between
List
1: dense, left
2: dense, center
3: dense, right
4: checkbox, left
5: checkbox, center
6: checkbox, right
7: dense, checkbox, left
8: dense, checkbox, center
9: dense, checkbox, right
10: checkbox, frequency, left
11: checkbox, frequency, center
12: checkbox, frequency, right
13: checkbox, frequency, histogram, left
14: checkbox, frequency, histogram, center
15: checkbox, frequency, histogram, right
Grid column
1: grid row, max rows 10, dense, checkbox mode, left, frequency
2: grid row, max rows 10, checkbox mode, center, frequency
3: grid row, max rows 10, checkbox mode, right, frequency
4: grid row, max rows 10, checkbox mode, left, frequency, histogram
5: grid row, max rows 10, dense, checkbox mode, center, frequency, histogram
6: grid row, max rows 10, checkbox mode, right, frequency, histogram
Grid row
1: grid column, max columns, dense, checkbox mode, left, frequency
2: grid column, max columns, checkbox mode, center, frequency
3: grid column, max columns, checkbox mode, right, frequency
4: grid column, max columns, checkbox mode, left, frequency, histogram
5: grid column, max columns, dense, checkbox mode, center, frequency, histogram
6: grid column, max columns, checkbox mode, right, frequency, histogram