This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat: zoom and pan mode #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haxxmaxx
reviewed
Feb 10, 2020
Caele
reviewed
Feb 11, 2020
Caele
approved these changes
Feb 12, 2020
henrikgildeus
approved these changes
Feb 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this would work when you set up zooming and panning from the start. However it does not consider state at all. So not sure what would happen if you have an active node different from the top node and resize. Will have to merge in the changes from Max to test that. However here a quick peak
Also would need to add something in PP to have the option to change between the modes
TODO: