Initial port of TMK's ibmpc_usb converter code #12821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into marfritkeebsandmaps
drashna
requested changes
May 27, 2021
Comment on lines
+19
to
+20
| #ifndef CONFIG_H | ||
| #define CONFIG_H |
There was a problem hiding this comment.
Suggested change
| #ifndef CONFIG_H | |
| #define CONFIG_H | |
| #pragma once |
| #define DEVICE_VER 0x0100 | ||
| #define MANUFACTURER QMK | ||
| #define PRODUCT PS/2 Keyboard | ||
| #define DESCRIPTION convert IBM PC keyboard to USB |
There was a problem hiding this comment.
Suggested change
| #define DESCRIPTION convert IBM PC keyboard to USB |
|
|
||
| #define IBMPC_INT_VECT INT1_vect | ||
|
|
||
| #endif |
Integrate suggested changes Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
fauxpark
requested changes
Jul 23, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
requested changes
Jul 23, 2021
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
requested changes
Jul 23, 2021
I removed the C++ stuff for the time being. |
|
Closed? Aw. QMK really needs this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I ported the ibmpc_usb converter from TMK.
hasu is combining the ps2_usb, terminal_usb and xt_usb converters in ibmpc_usb - and so should qmk.
Not entirely sure about the location of ibmpc.c and ibmpc.h, since they reside in /tmk_core/protocol/ in TMK.
Types of Changes
Issues Fixed or Closed by This PR
Checklist