Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use racks in ccg #186

Merged
merged 25 commits into from
Aug 3, 2021
Merged

Use racks in ccg #186

merged 25 commits into from
Aug 3, 2021

Conversation

vovac12
Copy link
Contributor

@vovac12 vovac12 commented Mar 4, 2021 •
edited
Loading

Closes #173

@vovac12 vovac12 requested a review from piakushin March 4, 2021 21:41
idruzhitskiy
idruzhitskiy requested changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@idruzhitskiy idruzhitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. There should be Result+Error Message instead of None+Logs
  2. There are hiddent mutability in center, rack etc methods (.inc()). It should be avoided, either by moving this counts to center (couple of Map<.., usize>), or marking those methods mutable. IMO first option is better and more maintainable

bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
bob-tools/bin/config_cluster_generator/center.rs Outdated Show resolved Hide resolved
idruzhitskiy
idruzhitskiy reviewed Apr 17, 2021
View reviewed changes
Copy link
Contributor

@idruzhitskiy idruzhitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions probably too large and should be split, otherwise LGTM

@agend
Copy link
Member

agend commented Apr 17, 2021

It just hit me that term rack is a bit weird,especially for cloud environments. Would it make sense to rename to availability group or something similar?

piakushin
piakushin suggested changes Apr 19, 2021
View reviewed changes
Copy link
Member

@piakushin piakushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide an example of cluster config with racks?

@vovac12
Copy link
Contributor Author

vovac12 commented Apr 19, 2021

Can you provide an example of cluster config with racks?

Done

piakushin
piakushin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@piakushin piakushin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piakushin piakushin merged commit 984e1fb into qoollo:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piakushin piakushin piakushin approved these changes

@idruzhitskiy idruzhitskiy Awaiting requested review from idruzhitskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The cluster configuration tool can take server racks into account during generation
4 participants
@vovac12 @agend @piakushin @idruzhitskiy