Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brt mode to reverse byte order #286

Merged
merged 30 commits into from
Nov 10, 2021

Conversation

vovac12
Copy link
Contributor

@vovac12 vovac12 commented Aug 11, 2021

Closes #281

Base automatically changed from brt-with-verification to master October 19, 2021 18:13
@ikopylov
Copy link
Member

Byte order reversion is essentially a migration from BLOB version 1 to version 2. Therefore, I propose to implement the migration semantic in this request:

  1. The command must be named migrate
  2. Target version must be passed as a parameter (if not specified, migrate to the latest)
  3. Migration logic should get starting version from BLOB file itself
  4. Migration logic should apply migrations sequentially from the starting version to the ending

bob-apps/bin/blob_recovery_tool/readers.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/readers.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/utils.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/utils.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/utils.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/utils.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/command.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/error.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/readers.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/readers.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/readers.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/readers.rs Outdated Show resolved Hide resolved
bob-apps/bin/blob_recovery_tool/structs.rs Outdated Show resolved Hide resolved
@piakushin piakushin merged commit 05738f8 into master Nov 10, 2021
@piakushin piakushin deleted the 281-brt-mode-to-reverse-byte-order branch November 10, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a mode to brt that reverses the byte order of the keys
4 participants