Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observer worker never stops bug fix, improve Arc placement and visibility levels #265

Merged
merged 24 commits into from
May 5, 2023
Merged

Observer worker never stops bug fix, improve Arc placement and visibility levels #265

merged 24 commits into from
May 5, 2023

Conversation

ikopylov
Copy link
Member

@ikopylov ikopylov commented May 2, 2023

Closes #259
Closes #185
Closes #186

ikopylov added 19 commits May 2, 2023 15:22
@ikopylov
[259] Place Inner in single Arc
3d3b986
@ikopylov
[259] Remove unneeded fields
98a705f
@ikopylov
[259] Improve visibility levels
fab86b7
@ikopylov
[259] Dump semaphore access simplified
48d2bcb
@ikopylov
[259] Remove async_oplock
a13182d
@ikopylov
[259] Observer with states
7f4ff50
@ikopylov
[259] Add tick with deadline (this is required to remove loopback sen…
60f75a6 
…der)
@ikopylov
[259] Remove loopback sender from ObserverWorker
c72639c
@ikopylov
[259] Remove dump_semaphore from ObserverWorker
c7ed7ec
@ikopylov
[259] Track observer worker completion with JoinHandle
4c2d890
@ikopylov
[259] Wait for observer worker stop in Storage::close
1f83b7a
@ikopylov
[259] Add test clean-up where it is missed
f76a835
@ikopylov
[259] Remove unneeded blob boxing
384f180
@ikopylov
[259] Update old blobs indexes dump logic (reduce blocking period)
77e6625
@ikopylov
[259] Run index dump in background task and track its completion
29f2097
@ikopylov
[259] Remove double predicate check
ce89ed8
@ikopylov
[259] Run multithread test in multithread runtime
385c9ab
@ikopylov
[259] Use read lock on safe in 'delete' when it is possible
d6bc6c1
@ikopylov
[259] Update CHANGELOG.md
b2fc3e4
@ikopylov ikopylov mentioned this pull request May 2, 2023
Closed
idruzhitskiy
idruzhitskiy reviewed May 3, 2023
View reviewed changes
src/storage/observer.rs Outdated Show resolved Hide resolved
src/storage/observer_worker.rs Outdated Show resolved Hide resolved
tests/common.rs Outdated Show resolved Hide resolved
@idruzhitskiy
Copy link
Contributor

LGTM

@ikopylov ikopylov merged commit c71d6a5 into master May 5, 2023
@ikopylov ikopylov mentioned this pull request May 5, 2023
Closed
This was referenced May 9, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idruzhitskiy idruzhitskiy idruzhitskiy left review comments

Assignees
No one assigned
Labels
required for release
Projects
None yet
Milestone
No milestone
2 participants
@ikopylov @idruzhitskiy